Skip to content

Skip pull-request-build on master push#6934

Merged
dagnir merged 2 commits intomasterfrom
dongie/no-pr-build-on-master
May 1, 2026
Merged

Skip pull-request-build on master push#6934
dagnir merged 2 commits intomasterfrom
dongie/no-pr-build-on-master

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented May 1, 2026

Motivation and Context

The runs pushes to master always fail because PR_NUMBER is absent, so the script invocation fails:

[2026-05-01T17:28:57.403Z] --pr-number value is required! Error: Process completed with exit code 1.

Running this on master push is redunant anyway because PR's go through the merge queue first, where this script does run correctly.

Example failure: https://github.com/aws/aws-sdk-java-v2/actions/runs/25224921002/job/73965992456

Modifications

  • Remove master push trigger.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

The runs pushes to master always fail because PR_NUMBER is absent, so
the script invocation fails:

[2026-05-01T17:28:57.403Z] --pr-number value is required!
Error: Process completed with exit code 1.

Running this on master push is redunant anyway because PR's go through
the merge queue first, where this script *does* run correctly.
@dagnir dagnir requested a review from a team as a code owner May 1, 2026 18:35
@dagnir dagnir enabled auto-merge May 1, 2026 18:52
@dagnir dagnir added this pull request to the merge queue May 1, 2026
Merged via the queue into master with commit 006d95f May 1, 2026
11 of 12 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants